Spring, Hibernate C3P0 Connection Pool, physical connections not closed

Question

We have used Spring, Hibernate and C3P0 connection pooling. But connections are not getting closed even though we set maxIdleTime=3, maxConnectionAge=3, maxIdleTimeExcessConnections=1.

Following is dispatcher-servlet.xml code

    <bean id="dataSource" class="com.mchange.v2.c3p0.ComboPooledDataSource" destroy-method="close">
        <property name="driverClass" value="com.microsoft.sqlserver.jdbc.SQLServerDriver"/>
        <property name="jdbcUrl" value="${jdbcUrl}"/>
        <property name="user" value="${user}"/>
        <property name="password" value="${password}"/>
        <property name="maxPoolSize" value="10"/>
        <property name="initialPoolSize" value="2"/>
        <property name="acquireIncrement"  value="1"/>          
        <property name="minPoolSize" value="1"/>
        <property name="maxIdleTime" value="3"/>
        <property name="maxConnectionAge" value="3"/>
        <property name="maxIdleTimeExcessConnections" value="1"/>        
    </bean>

    <bean id="sessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean"> 
        <property name="dataSource" ref="dataSource"/>
        <property name="configLocation">
            <value>classpath:hibernate.cfg.xml</value>
        </property>
        <property name="ConfigurationClass">
            <value>org.hibernate.cfg.AnnotationConfiguration</value>
        </property>
        <property name="hibernateProperties">
            <props>
                <prop key="hibernate.show_sql">false</prop>
                <prop key="hibernate.dialect">org.hibernate.dialect.SQLServerDialect</prop>
            </props>  
        </property>         
    </bean>         

    <tx:annotation-driven/>

    <bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">
        <property name="sessionFactory" ref="sessionFactory"></property>
    </bean>

    <mvc:annotation-driven/>

Following is Service and DAO Implementation Code

Service Implemention Class

@Service
public class SaveFeedbackServiceImpl implements SaveFeedbackService 
{ 

    @Autowired
    private SaveFeedBackDAO saveFeedbackDAO;


    @Transactional
    public void saveStudentTestFeedback(FeedbackMaster fm,String akey,int testid)
    {
        saveFeedbackDAO.saveStudentTestFeedback(fm, akey, testid);
    }
}

DAO Implementation Class

@Repository
public class SaveFeedBackImpl implements SaveFeedBackDAO
{

        @Autowired
    private SessionFactory sessionFactory; 

    @Override
    public void saveStudentTestFeedback(FeedbackMaster fm,String akey,int testid)
    {


        Criteria criteria = sessionFactory.getCurrentSession().createCriteria(FeedbackMaster.class);
        criteria.add(Restrictions.eq("accesskey", akey)).add(Restrictions.eq("testid", testid));

        FeedbackMaster fdkm = (FeedbackMaster) criteria.uniqueResult();

        fdkm.setFbq1(fm.getFbq1());
        fdkm.setFbq2(fm.getFbq2());
        fdkm.setFbq3(fm.getFbq3());
        fdkm.setFbq4(fm.getFbq4());
        fdkm.setFbq5(fm.getFbq5());
        fdkm.setFbq6(fm.getFbq6());
        fdkm.setFbq7(fm.getFbq7());
        fdkm.setFbq8(fm.getFbq8());
        fdkm.setFbq9(fm.getFbq9());
        fdkm.setFbq10(fm.getFbq10());


        sessionFactory.getCurrentSession().update(fdkm);


        String hql = " UPDATE StudentTestDetail set testStatus=:testStatus "+
                     " WHERE accesskey = :akey and testid=:testid ";

         Query query = sessionFactory.getCurrentSession().createQuery(hql);
         query.setParameter("testStatus",4);
         query.setParameter("akey",akey);
         query.setParameter("testid",testid);        
         query.executeUpdate();


    }

}    

Thanks in Advance.

Answer 1

We have used the following line in the dispatcher-servlet.xml file and now database physical connections are now closing.
<tx:annotation-driven proxy-target-class="true" transaction-manager="transactionManager"/>