Search code examples
phparraysmedoo

PHP Error: Cannot use a scalar value as an array... However

I'm currently working with the medoo.php framework, and although I would normally use their ticket area on github, it appears that no one actually uses that... so... At any rate, when I'm running one of my files which uses "require" to call the framework, I get the following error:

Warning: Cannot use a scalar value as an array in /home/..../public_html/projects/friendcodes/medoo.min.php on line 759

However, when I inspect the code (the below is lines 752 to 764), I see that it is in fact supposed to check if $where is not set, and if it isn't, make it an array - however this php error begs to differ.

I'm guessing that $where is being set as a variable somewhere else, that's not an array, but there are over 100 occurrences of the variable in the framework, and 830 lines of code, which you probably don't want to see. (Let me know in a comment and I'll add it - again, this is directly from medoo's most two recent updates/releases.)

public function get($table, $columns, $where = null)
{
    if (!isset($where))
    {
        $where = array();
    }

    $where['LIMIT'] = 1;

    $data = $this->select($table, $columns, $where);

    return isset($data[0]) ? $data[0] : false;
}

My main question is - How do I rectify this problem without breaking something in this framework which is extremely complex (for my level, at any rate)

Update: How silly of me! I found the problem. Just as people suggested, I was calling $where wrong. I was calling it with:

$accountinfo = $database->get('xf_user_field_value', ['field_value'], 1);

Instead of

$accountinfo = $database->get('xf_user_field_value', ['field_value'], ["user_id"=>1]);

(Where the third arg is $where) Thanks for the help guys!

Solution

  • Right, first things first, we need to find out what is calling get that shouldn't be. WHICH IS THE ENTIRE PROBLEM. The problem isn't the function itself, the problem is something is calling it using an argument for $where which isn't an array. Changing a library to fix one faulty call is ridiculous.

    Step 1: Temporarily edit the get function to include a print_r of the $where variable.

    public function get($table, $columns, $where = null)
{
    if(isset($where)) print_r($where);
    if (!isset($where))
    {
        $where = array();
    }

    $where['LIMIT'] = 1;

    $data = $this->select($table, $columns, $where);

    return isset($data[0]) ? $data[0] : false;
}

    This will show us before the error prints the value of $where, which will help you find the malformed get call.

    If this fails, try using PHP's built-in backtrace to try to find the issue:

    public function get($table, $columns, $where = null)
{
    if(isset($where)) print_r(debug_backtrace());
    if (!isset($where))
    {
        $where = array();
    }

    $where['LIMIT'] = 1;

    $data = $this->select($table, $columns, $where);

    return isset($data[0]) ? $data[0] : false;
}