ListView Holder check checbox Bug

Question

I'm developing an app with a custom layout and an arrayAdapter:

The problem is when I check one Box the app automatically check another 2 boxes!

I created a list where I put the positions of checkboxes and show that nothing its wrong! I think the problem is when I do the recycle!

Lets view some code; This is my ArrayAdapter:

class VivzAdapter extends ArrayAdapter<String> implements OnCheckedChangeListener {
Context context;
int[] images;
String[] titlesArray, descrptionArray;
List<Integer> positions = new ArrayList<Integer>();

VivzAdapter(Context context, String[] titles, int[] images, String[] description) {

    super(context, R.layout.single_row, R.id.textView1, titles);
    this.context = context;
    this.images = images;
    this.titlesArray = titles;
    this.descrptionArray = description;
}

class MyViewHolder {
    ImageView myImage;
    TextView myTitle;
    TextView myDescription;
    CheckBox box;

    MyViewHolder(View v) {
        myImage = (ImageView) v.findViewById(R.id.imageView1);
        myTitle = (TextView) v.findViewById(R.id.textView1);
        myDescription = (TextView) v.findViewById(R.id.textView2);
        box = (CheckBox) v.findViewById(R.id.checkBox1);
    }
}

@Override
public View getView(int position, View convertView, ViewGroup parent) {
    View row = convertView;
    MyViewHolder holder = null;
    if (row == null) {
        // 1.ºtime
        LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

        //row contem RelativeLayout(root) em single_row.xml
        row = inflater.inflate(R.layout.single_row, parent, false);
        holder = new MyViewHolder(row);
        row.setTag(holder);
        //Log.d("VIVZ", "Creating a new Row");
    } else {
        //reciclamos aqui, qeremos usar antigo objecto holder
        holder = (MyViewHolder) row.getTag();
        //Log.d("VIVZ", "Recycling stuff");
    }
    holder.myImage.setImageResource(images[position]);
    holder.myTitle.setText(titlesArray[position]);
    holder.myDescription.setText(descrptionArray[position]);
    holder.box.setTag(position);
    holder.box.setOnCheckedChangeListener(this);
    return row;
}

@Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
    if(isChecked){
        int position = (Integer)buttonView.getTag();
        Toast.makeText(getContext(), ""+position, Toast.LENGTH_SHORT).show();
        positions.add(position);
        Log.d("VIVZ", "+ "+position);
    } else {
        int position = (Integer)buttonView.getTag();
        Toast.makeText(getContext(), ""+position, Toast.LENGTH_SHORT).show();
        Log.d("VIVZ", "- "+position);
        positions.remove(position);
    }
    Log.d("VIVZ", positions.toString());
}
}

Answer 1

I was stucked in same problem and found the solution. Create a boolean array having size same as no. of elements in the list and initial value false for each list item. Then in getView set position in Id through setId for checkbox. Now set the value of checkbox from boolean array through setChecked method of checkbox. Add onClickListener for checkbox and in this listener change the value in boolean array not checkbox value directly. I hope this resolve your problem also.

Just replace your adapter class with this code :

class VivzAdapter extends ArrayAdapter<String> implements OnCheckedChangeListener {
Context context;
int[] images;
String[] titlesArray, descrptionArray;
List<Integer> positions = new ArrayList<Integer>();

ArrayList<Boolean> arrChecked;

VivzAdapter(Context context, String[] titles, int[] images, String[] description) {

super(context, R.layout.single_row, R.id.textView1, titles);
this.context = context;
this.images = images;
this.titlesArray = titles;
this.descrptionArray = description;

// initialize arrChecked boolean array and add checkbox value as false initially for each item of listview
arrChecked = new ArrayList<Boolean>();
for (int i = 0; i < titles.size(); i++) {
arrChecked.add(false);
}
}

class MyViewHolder {
ImageView myImage;
TextView myTitle;
TextView myDescription;
CheckBox box;

MyViewHolder(View v) {
    myImage = (ImageView) v.findViewById(R.id.imageView1);
    myTitle = (TextView) v.findViewById(R.id.textView1);
    myDescription = (TextView) v.findViewById(R.id.textView2);
    box = (CheckBox) v.findViewById(R.id.checkBox1);
}
}

@Override
public View getView(int position, View convertView, ViewGroup parent) {
View row = convertView;
MyViewHolder holder = null;
if (row == null) {
    // 1.ºtime
    LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

    //row contem RelativeLayout(root) em single_row.xml
    row = inflater.inflate(R.layout.single_row, parent, false);
    holder = new MyViewHolder(row);
    row.setTag(holder);
    //Log.d("VIVZ", "Creating a new Row");
} else {
    //reciclamos aqui, qeremos usar antigo objecto holder
    holder = (MyViewHolder) row.getTag();
    //Log.d("VIVZ", "Recycling stuff");
}
holder.myImage.setImageResource(images[position]);
holder.myTitle.setText(titlesArray[position]);
holder.myDescription.setText(descrptionArray[position]);

//set position as id
holder.box.setId(position);
//set onClickListener of checkbox rather than onCheckedChangeListener
holder.box.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View v) {
            int id = v.getId();

            if (arrChecked.get(id)) {
                //if checked, make it unchecked
                arrChecked.set(id, false);
            } else {
                //if unchecked, make it checked
                arrChecked.set(id, true);

            }

        }
    });

    //set the value of each checkbox from arrChecked boolean array
    holder.box.setChecked(arrChecked.get(position));

return row;
}
}