I'm fan STL algorithms, so I frequently use many STL algorithms in my job. But,...
Consider following simple example: // Compiler: Visual Studio 2010 Sp1. Cpu: i5 3300MG.
struct FileInfo
{
std::string filename_;
std::string filename()const { return filename_;}
};
//works with 1000 FileInfos, Elapsed: 127.947 microseconds
std::string sumof_filenames_1(std::vector<FileInfo> const& fv )
{
std::string s;
for( std::size_t ix = 0u; ix < fv.size(); ++ix) s += fv[ix].filename();
return s;
}
//Elapsed: 7430.138 microseconds
std::string sumof_filenames_2(std::vector<FileInfo> const& fv )
{
struct appender{
std::string operator()(std::string const& s, FileInfo const& f)const
{ return s + f.filename(); }
};
return std::accumulate( std::begin(fv), std::end(fv), std::string(), appender() );
}
//Elapsed: 10729.381 microseconds
std::string sumof_filenames_3(std::vector<FileInfo> const& fv )
{
struct appender{
std::string operator()(std::string & s, FileInfo const& f) const
{ return s+= f.filename(); }
};
std::accumulate( std::begin(fv), std::end(fv), std::string(), appender() );
}
Q: How optimize sum_of_filenames using STL algorithms, such std::accumulate, or any others, and how to implement appender functor ?
test: main function :
int main()
{
enum{ N = 1000* 1 };
srand(14324);
std::vector<FileInfo> fv;
fv.reserve(N);
for(std::size_t ix = 0; ix < N; ++ix)
{
FileInfo f;
f.m_Filename.resize( static_cast< int > ( rand() * 256 / 32768 ) + 15 , 'A');
//for( std::size_t iy = 0; iy < f.m_Filename.size(); ++iy)
// f.m_Filename[iy] = static_cast<char>( rand() * 100 / 32768 + 28 );
fv.push_back( f );
}
LARGE_INTEGER freq, start, stop;
QueryPerformanceFrequency(&freq);
{
QueryPerformanceCounter(&start);
std::string s = sumof_filenames_1(fv);
QueryPerformanceCounter(&stop);
double elapsed = (stop.QuadPart - start.QuadPart)* 1000.0 / (double)(freq.QuadPart) * 1000.0;
printf("Elapsed: %.3lf microseconds\n", elapsed);
printf("%u\n", s.size());
}
{
QueryPerformanceCounter(&start);
std::string s = sumof_filenames_2(fv);
QueryPerformanceCounter(&stop);
double elapsed = (stop.QuadPart - start.QuadPart)* 1000.0 / (double)(freq.QuadPart) * 1000.0;
printf("Elapsed: %.3lf microseconds\n", elapsed);
printf("%u\n", s.size());
}
{
QueryPerformanceCounter(&start);
std::string s = sumof_filenames_3(fv);
QueryPerformanceCounter(&stop);
double elapsed = (stop.QuadPart - start.QuadPart)* 1000.0 / (double)(freq.QuadPart) * 1000.0;
printf("Elapsed: %.3lf microseconds\n", elapsed);
printf("%u\n", s.size());
}
Try to estimate the following function
std::string sumof_filenames_3(std::vector<FileInfo> const& fv )
{
struct appender{
std::string & operator()(std::string & s, FileInfo const& f) const
{ return s+= f.filename(); }
};
return std::accumulate( std::begin(fv), std::end(fv), std::string(), appender() );
}
and with using a lambda expression
std::string sumof_filenames_3(std::vector<FileInfo> const& fv )
{
return std::accumulate( std::begin(fv), std::end(fv), std::string(),
[]( std::string &s, FileInfo const& f ) -> std::string &
{
return s += f.filename();
} );
}
Also estimate the following loop
std::string sumof_filenames_1(std::vector<FileInfo> const& fv )
{
std::string::size_type n = 0;
for each ( FileInfo const& f in fv ) n += f.filename().size();
std::string s;
s.reserve( n );
for( std::size_t ix = 0u; ix < fv.size(); ++ix) s += fv[ix].filename();
return s;
}
Also do the same estimations for the structure defined the following way
struct FileInfo
{
std::string filename_;
const std::string & filename()const { return filename_;}
};