I am trying to create a cursor that inserts the first record in the temporary table. After that it should fetch next record and compare the employeeId + date(format 05/05/2014) with the previous record employeeId + date. If it is the same, it should update the previous record Time out data with the the current record tim out data. else it should insert new row.
I have table in my database with the following columns:
employeeID(int), employeeName varchar(max), Time datetime.
1 , Tim , 05/05/2014 08:15:42
1 , Tim , 05/05/2014 16:30:51
1 , Tim , 06/23/2014 07:00:00
1 , Tim , 06/23/2014 09:00:00
1 , Tim , 06/23/2014 11:00:00
1 , Tim , 06/23/2014 16:30:00
I created a temp table with the following columns and my end result should look like the information below.
employeeID, employeeName , Time in , Time out
1 , Tim , 05/05/2014 08:15:42 , 05/05/2014 16:30:51
1 , Tim , 06/23/2014 07:00:00 06/23/2014 16:30:00
Below is the code I have
Drop Table #temp
go
Create Table #temp
(
userid int,
empname varchar(50),
checkin datetime,
checkout datetime
)
Declare @empid int, @empname varchar(50), @date1 datetime, @strdate varchar(12);
Declare @date2 datetime, @time datetime, @loop int;
Declare Report Cursor
For select e.employeeId,e.name,tp.TimePunch, tp.TimePunch as date2,
CONVERT(VARCHAR(10),TimePunch,110) as stringDate
from EmpTimePunch tp
left join EmploeeInfo e on tp.employeeId = tp.employeeId
where (DATEDIFF(s,'2014-05-01 00:00:00.000',TimePunch) >=0
and DATEDIFF(s,getdate(),TimePunch)<=0)
order by employeeId,TimePunch
Open Report
-- looking at each record
Fetch Next From Report
Into @empid, @empname, @date1, @date2,@strdate
declare @empDate varchar(50);
declare @empDate2 varchar(50);
set @empDate = '';
set @empDate2 = '';
set @loop = 0
--0 equals true; while fetching equal true
while @@FETCH_STATUS = 0
Begin
-- insert first record in temp table
if @loop != 0 and @empDate = @empDate2
insert into #temp values(@empid, @empname, @date1, @date2)
--I want to compare the next record
-- if next record have same employee id and date2(05/05/2014) as prievous record.
--update previous record date2 with the date2 from record 2
set @empDate = cast(@empid as varchar(10))+ @strdate;
fetch next from report
Into @empid, @empname, @date1, @date2,@strdate
End
close Report
Deallocate Report
select * from #temp
As a rule of thumb, iterative logic should be avoided in SQL. Wherever possible, the declarative nature of the language should be exploited - expressing your code as a set-based query.
I propose a solution like this or similar to this;
;WITH MyData (employeeID, employeeName, [Time])
AS
(
SELECT 1, 'Tim', '05/05/2014 08:15:42' UNION ALL
SELECT 1, 'Tim', '05/05/2014 16:30:51' UNION ALL
SELECT 1, 'Tim', '06/23/2014 07:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 09:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 11:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 16:30:00'
)
SELECT employeeID
,employeeName
,[Time In] = MIN([Time])
,[Time Out] = MAX([Time])
FROM MyData
GROUP BY employeeID, employeeName, CAST([Time] AS DATE)
If you are new to or uncomfortable with CTE
s;
CREATE TABLE #MyData
(
employeeID INT,
employeeName VARCHAR(50), -- Please use VARCHAR(MAX) as infrequently as possible
ClockTime DATETIME -- In this example, I've changed the field name from [Time] to ClockTime
) -- It is best to avoide reserved words for object\field naming
INSERT INTO #MyData (employeeID, employeeName, ClockTime)
SELECT 1, 'Tim', '05/05/2014 08:15:42' UNION ALL
SELECT 1, 'Tim', '05/05/2014 16:30:51' UNION ALL
SELECT 1, 'Tim', '06/23/2014 07:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 09:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 11:00:00' UNION ALL
SELECT 1, 'Tim', '06/23/2014 16:30:00'
SELECT employeeID
,employeeName
,[Time In] = MIN(ClockTime)
,[Time Out] = MAX(ClockTime)
FROM #MyData
GROUP BY employeeID, employeeName, CAST(ClockTime AS DATE)
Footnote;
I'm sure my sentiment will be echoed when I suggest that CURSORS
are the last thing you should ever try to learn in SQL. This will hopefully "force" you in to trying set-based approaches.