Search code examples
cloopsstructpoker

How come my straight counter remains at a value of zero?


I am making a program in the C90 standard using GCC in Ubuntu 10.04, that randomly generates a hand of 5 card structs and calculates if the hand is a flush, straight, etc.

My function to calculate straights is:

int isStraight(card hand[]) {
    int i, count = 1, result = 0;
    for (i = 0; i < HAND_SIZE-1; i++) {
        if (hand[i].pips == ((hand[i+1].pips) + 1)) {
            count++;
        }
    }
    if (count == HAND_SIZE)
        result = 1;
    return result;
}

My main function:

int main(void) {

    int i, j;
    int numHands = 0;
    int flushCount = 0;
    int straightCount = 0;
    int xOfAKindCount = 0;
    int straightFlushCount = 0;
    int fullHouseCount = 0;
    int isTwoPairCount = 0;

    card deck[DECKSZ] = {0};
    card hand[HAND_SIZE] = {0};

    stack deckStack = {0};
    stack handStack = {0};

    initDeck(deck);
    shuffleDeck(deck);
    reset(&deckStack);

    for (i = 0; i < DECKSZ; i++) {
        push(deck[i], &deckStack);
    }

    do {
        reset(&handStack);
        for (i = 0; i < HAND_SIZE; i++) {
            push(pop(&deckStack), &handStack);
            if (isEmpty(&deckStack)) {
                reset(&handStack);
                shuffleDeck(deck);
                reset(&deckStack);
                for (j = 0; j < DECKSZ; j++) {
                    push(deck[j], &deckStack);
                }
            }
                hand[i] = handStack.s[i];
            }

        numHands += 1;
        arrangeHand(hand);

        flushCount += isFlush(hand);
        straightCount += isStraight(hand);
        xOfAKindCount += isXOfAKind(hand, 2, 0);
        straightFlushCount += isStraightFlush(hand);
        fullHouseCount += isFullHouse(hand);
        isTwoPairCount += isTwoPair(hand);

        printf("Flushes:%d Straights:%d SF's:%d Number of Hands:%d\r",
            flushCount, straightCount, straightFlushCount, numHands);
    } while (1);

    printf("\n");

    return EXIT_SUCCESS;
}

My issue is my variable declared inside my function, result, is never set to 1 to indicate whether or not the hand is a straight, which therefore means my straightCount variable always remains at a value of zero. I do not have access to a debugger and in my mind the code I have makes sense. I'm new to programming in C, so if anybody could help me point out what is wrong with my function, I'd appreciate it. Thanks!


Solution

  • int isStraight(card hand[]) {
      int step = 0;
      for(int i = 1;i < HAND_SIZE; i++)
        if(hand[i].pip != hand[i-1].pip+1)
          /* Substitute step with i!=1 if over-edge invalid */
          if(step || hand->pip != 1 || hand[i].pip != hand[i-1].pip+13-HAND_SIZE)
            return 0;
          else
            step = 1;
      return 1;
    }