Search code examples
javaandroidsqlitelogcatfatal-error

sqlite database not working error 638

Whenever i want to add a row to a database column on android, it gives me a fatal error and LogCat doesn't tell me what causes the issue. It just tells me the file and the PID, whch also tells me that it's a fatal error and the PID number is 638.

Basically, I need a Dialog to show with the input fields that the user needs to fill in in order to add the appointment to the database.

Code:

    package com.example.calendar;

import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.CalendarView;
import android.widget.EditText;
import android.app.Activity;
import android.content.Intent;
import static android.provider.BaseColumns._ID;
import static com.example.calendar.Constants.TABLE_NAME;
import static com.example.calendar.Constants.TIME;
import static com.example.calendar.Constants.TITLE;
import static com.example.calendar.Constants.DETAILS;
import static com.example.calendar.Constants.DATE;
import static com.example.calendar.Constants.CONTENT_URI;
import android.content.ContentValues;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;


public class CreateAppointment extends Activity implements OnClickListener{

    private static String[] FROM = { _ID, DATE, TIME, TITLE, DETAILS};
    private static String ORDER_BY = TIME + " ASC";
    private AppointmentsData appointments;
    CalendarView calendar;
    String string;
    EditText nameTextBox;
    EditText timeTextBox;
    EditText detailsTextBox;

    protected void onCreate(Bundle savedInstanceState) {

        super.onCreate(savedInstanceState);
        setContentView(R.layout.create);

        View createButton = findViewById(R.id.apptSave);
        View nameTextBox = (EditText)findViewById(R.id.apptName);
        View timeTextBox = (EditText)findViewById(R.id.apptTime);
        View detailsTextBox = (EditText)findViewById(R.id.apptDetails);
        calendar = (CalendarView)findViewById(R.id.calendar);
        createButton.setOnClickListener(this);

    }

    private void addAppointment(String string) {
        /* Insert a new record into the Events data
        source. You would do something similar
        for delete and update. */
        String getTitle = nameTextBox.toString();
        String getTime = timeTextBox.toString();
        String getDetails = detailsTextBox.toString();

        SQLiteDatabase db = appointments.getWritableDatabase();
        ContentValues values = new ContentValues();
        values.put(DATE, calendar.getDate());
        values.put(TIME, getTime);
        values.put(TITLE, getTitle);
        values.put(DETAILS, getDetails);
        getContentResolver().insert(CONTENT_URI, values);
        }

    @Override
    public void onClick(View v) {
        // TODO Auto-generated method stub
        switch(v.getId()){

        case R.id.apptSave:
            addAppointment(string);
            finish();
            break;

        }

    }

}

Stacktrace:

    03-17 15:32:21.547: E/AndroidRuntime(638): FATAL EXCEPTION: main
03-17 15:32:21.547: E/AndroidRuntime(638): java.lang.NullPointerException
03-17 15:32:21.547: E/AndroidRuntime(638):  at com.example.calendar.CreateAppointment.addAppointment(CreateAppointment.java:51)
03-17 15:32:21.547: E/AndroidRuntime(638):  at com.example.calendar.CreateAppointment.onClick(CreateAppointment.java:70)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.view.View.performClick(View.java:3480)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.view.View$PerformClick.run(View.java:13983)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.os.Handler.handleCallback(Handler.java:605)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.os.Handler.dispatchMessage(Handler.java:92)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.os.Looper.loop(Looper.java:137)
03-17 15:32:21.547: E/AndroidRuntime(638):  at android.app.ActivityThread.main(ActivityThread.java:4340)
03-17 15:32:21.547: E/AndroidRuntime(638):  at java.lang.reflect.Method.invokeNative(Native Method)
03-17 15:32:21.547: E/AndroidRuntime(638):  at java.lang.reflect.Method.invoke(Method.java:511)
03-17 15:32:21.547: E/AndroidRuntime(638):  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
03-17 15:32:21.547: E/AndroidRuntime(638):  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
03-17 15:32:21.547: E/AndroidRuntime(638):  at dalvik.system.NativeStart.main(Native Method)

Please help.

Solution

  • You have re-declared the variables in onCreate making it local to onCreate where as the instance variables are not initialized.

    Hence NPE @ CreateAppointment.java line 51 which is probably String getTitle = nameTextBox.toString();

    Change to

    EditText nameTextBox;
EditText timeTextBox;
EditText detailsTextBox;
Button createButton ;
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.create);
createButton = (Button)findViewById(R.id.apptSave);
nameTextBox = (EditText)findViewById(R.id.apptName);
timeTextBox = (EditText)findViewById(R.id.apptTime);
detailsTextBox = (EditText)findViewById(R.id.apptDetails);
calendar= (CalendarView)findViewById(R.id.calendar);

    And change this

    String getTitle = nameTextBox.toString();
String getTime = timeTextBox.toString();
String getDetails = detailsTextBox.toString();

    to

    String getTitle = nameTextBox.getText().toString();
String getTime = timeTextBox.getText().toString();
String getDetails = detailsTextBox.getText().toString();

    Edit:

    See this

    private AppointmentsData appointments;
String string;

    Only declared not initialized.

    1. You have not initialized string.

    2. You have not initialized appointments.

       appointments = new AppointmentsData(this); // after activity is created
 // can be initialized in onCreate

    hence you get NPE