Search code examples
androidandroid-activityreusability

What's wrong with click handling of my buttons inside a reusable layout?


I have a reusable layout with a back button. I want to handle click event of my back button from BaseActivity. I set the onClick of the button to "headerClickHandler" and I have a method with this name in BaseActivity but When I click the button, an error says there is no headerClickHandler. What's wrong? this is my Header.xml:

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <TextView android:id="@+id/txtHeading"
        android:text="@string/general_title"
        android:layout_alignParentTop="true"
        android:layout_alignParentRight="true"
        android:layout_height="30dp"
        android:layout_width="200dp"/>

    <Button android:id="@+id/btnBack"
        android:layout_alignParentTop="true"
        android:layout_alignParentLeft="true"
        android:layout_height="30dp"
        android:layout_width="100dp"
        android:background="@color/red_hover"
        android:text="@string/return_value"
        android:onClick="headerClickHandler"
        />


</RelativeLayout>

This is My BaseActivity:

public class BaseActivity extends Activity {
    public void headerClickHandler(View v) {
        switch (v.getId()) {
        case R.id.btnBack:
            Toast.makeText(this, "TEST", Toast.LENGTH_LONG).show();
            break;

        default:
            break;
        }
    }

}

this is my activity:

public class PersonnelInfo extends BaseActivity {
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_personnel_info);

    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        getMenuInflater().inflate(R.menu.personnel_info, menu);
        return true;
    }
}

Solution

  • Remove android:onClick="headerClickHandler" from xml

    In base activity:

    public class BaseActivity extends Activity {
    
        public OnClickListener headerClickHandler = new OnClickListener() {
            public void onClick(View v) {
                switch (v.getId()) {
                case R.id.btnBack:
                    Toast.makeText(BaseActivity.this, "TEST", Toast.LENGTH_LONG).show();
                    break;
    
                default:
                    break;
                }
            }
        };
    
    }  
    

    In derive activity:

    Button btnBack = (Button) findViewById(R.id.btnBack);
    btnBack.setOnClickListener(headerClickHandler);