Search code examples
angularjsmodel-binding

Bind Angularjs to newly created html element dynamically


I have a tab page with multiple tabs that once clicked on call a service to return some data. Some of that data returns html forms and are very random. I want to collect those values that are entered and send the data via a service back to the server. The problem I have is that I can't get the data from the input elements in the html I'm creating dynamically.

I've created a Plunker to show what the issue is. Note that the html value can change at any time so hard-coding the html won't work. Here the code from the plunker, but please look at the plunker for the best view of whats going on.

app.js

var app = angular.module('plunker', []);

app.controller('MainCtrl', function($scope, $sce, $compile) {
    $scope.name = 'World';
    $scope.html = "";

    $scope.htmlElement = function(){
        var html = "<input type='text' ng-model='html'></input>";
        return $sce.trustAsHtml(html);
    }

});

index.html

<!DOCTYPE html>
<html ng-app="plunker">

  <head>
    <meta charset="utf-8" />
    <title>AngularJS Plunker</title>
    <script>document.write('<base href="' + document.location + '" />');</script>
    <link rel="stylesheet" href="style.css" />
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.0-rc.3/angular.js"></script>
    <script src="app.js"></script>
  </head>

  <body ng-controller="MainCtrl">
    <p>Hello {{name}}!</p>

    <div ng-bind-html="htmlElement()"></div>

    {{html}}

  </body>

</html>

Solution

  • One solution would be to use ngInclude with $templateCache, as demonstrated in this Plunker.

    There are a couple things to note.

    The first is that you can fetch your template using a service and add it to the $templateCache, as described here (example copied):

    myApp.service('myTemplateService', ['$http', '$templateCache', function ($http, $templateCache) {
      $http(/* ... */).then(function (result) {
        $templateCache.put('my-dynamic-template', result);
      });
    }]);
    

    Then you can include it in your template as follows:

    <div ng-include="'my-dynamic-template'"></div>
    

    ngInclude will allow databinding on the html string, so you don't need ngBindHtml.

    The second is that, as ngInclude creates a new scope, accessing the html property outside of the newly created scope won't work properly unless you access it via an object on the parent scope (e.g. ng-model="data.html" instead of ng-model="html". Notice that the $scope.data = {} in the parent scope is what makes the html accessible outside of the ngInclude scope in this case.

    (See this answer for more on why you should always use a dot in your ngModels.)


    Edit

    As you pointed out, the ngInclude option is much less useful when using a service to return the HTML.

    Here's the edited plunker with a directive-based solution that uses $compile, as in David's comment above.

    The relevant addition:

    app.directive('customHtml', function($compile, $http){
      return {
        link: function(scope, element, attrs) {
          $http.get('template.html').then(function (result) {
            element.replaceWith($compile(result.data)(scope));
          });
        }
      }
    })