Search code examples
pythonpalindrome

Where's the bug in this function to check for palindrome?

Given below is the code to check if a list is a palindrome or not. It is giving correct output for 983. Where am I going wrong?

def palindrome(num):
    flag=0
    r=num[::-1]
    for i in range (0, len(num)-1):
        if(r[i]==num[i]):
            flag=1
        else:
            flag=0
    return flag
Solution

  • You should return as soon as there is a mismatch. Also, you just need to iterate till half the length:

    def function(...):
    ...
    for i in range (0, (len(num) + 1) / 2):
        if r[i] != num[i]:
            return False
    return True

    BTW, you don't need that loop. You can simply do:

    def palindrome(num):
    return num == num[::-1]