Show alert dialog in chrome extension

Question

I want to display a simple alert when user clicks on my extension icon. I have tried this code :

chrome.browserAction.onClicked.addListener(
    alert(1)
);

Here is my manifest :

{
  "manifest_version": 2,

  "name": "sample",
  "description": "des",
  "version": "1.0",

  "browser_action": {
    "default_icon": "icon.png"
  },
  "permissions": [
  ]
}

How do I show an alert onClick event ?

Answer 1

updated:

According the browserAction documentation it is like:

chrome.browserAction.onClicked.addListener(function() { 
  alert('Hello, World!'); 
})

and here is the sample from Google (zip-file):

// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

var min = 1;
var max = 5;
var current = min;

function updateIcon() {
  chrome.browserAction.setIcon({path:"icon" + current + ".png"});
  current++;

  if (current > max)
    current = min;
}

chrome.browserAction.onClicked.addListener(updateIcon);
updateIcon();