Defining Faces - GNU Emacs Lisp Reference Manual says that a face name should not end in -face, but when I run list-faces-display there are some face names that end with that. If I were to write a package which uses its own faces, should I use the -face suffix?
What about user variables that hold faces? Should the variable names end in -face?
If the manual says that you shouldn't do it, don't do it.
The ones that end with -face are old holdovers that were written before
the rule came into place, and haven't been rewritten yet.
The variables that hold faces is something similar to a box that can hold exactly one box of the same size. Not very useful. You can get by without them, I think.