Search code examples
c#.nettransactionstransactionscope

Data committed even though System.Transactions.TransactionScope.Commit() not called


Under what circumstances can code wrapped in a System.Transactions.TransactionScope still commit, even though an exception was thrown and the outermost scope never had commit called?

There is a top-level method wrapped in using (var tx = new TransactionScope()), and that calls methods that also use TransactionScope in the same way.

I'm using typed datasets with associated tableadapters. Could it be that the commands in the adapter aren't enlisting for some reason? Do any of you know how one might check whether they are enlisting in the ambient TransactionScope or not?


Solution

  • The answer turned out to be because I was creating the TransactionScope object after the SqlConnection object.

    I moved from this:

    using (new ConnectionScope())
    using (var transaction = new TransactionScope())
    {
        // Do something that modifies data
    
        transaction.Complete();
    }
    

    to this:

    using (var transaction = new TransactionScope())
    using (new ConnectionScope())
    {
        // Do something that modifies data
    
        transaction.Complete();
    }
    

    and now it works!

    So the moral of the story is to create your TransactionScope first.