Search code examples
androidandroid-actionbaractionbarsherlockandroid-tabs

Fragment is re created when ActionbarSherlock tab is selected


I have a Fragment Activity which holds three fragments.

public class MainActivity extends SherlockFragmentActivity {
/** Called when the activity is first created. */

@Override
public void onCreate(Bundle savedInstanceState) {

    super.onCreate(savedInstanceState);

    ActionBar bar = getSupportActionBar();
    bar.setNavigationMode(ActionBar.NAVIGATION_MODE_TABS);

    ActionBar.Tab tab1 = bar.newTab();
    ActionBar.Tab tab2 = bar.newTab();
    ActionBar.Tab tab3 = bar.newTab();
    tab1.setText("");
    tab1.setIcon(R.drawable.abs__ic_menu_share_holo_dark);
    tab2.setText("");
    tab2.setIcon(R.drawable.abs__ic_voice_search);
    tab3.setText("");
    tab3.setIcon(R.drawable.abs__ic_cab_done_holo_dark);

    if (savedInstanceState == null) {

        tab1.setTabListener(new MyTabListener());
        tab2.setTabListener(new MyTabListener());
        tab3.setTabListener(new MyTabListener());
        bar.addTab(tab1);
        bar.addTab(tab2);
        bar.addTab(tab3);

    }
}

private class MyTabListener implements ActionBar.TabListener {
    @Override
    public void onTabSelected(Tab tab, FragmentTransaction ft) {

        switch (tab.getPosition()) {
        case 0:

            FeedsActivity frag = new FeedsActivity();

            ft.replace(android.R.id.content, frag);
            return;

        case 1:
            ProfileActivity frag2 = new ProfileActivity();
            ft.replace(android.R.id.content, frag2);
            return;
        case 2:
            MyMemoirsActivity frag3 = new MyMemoirsActivity();
            ft.replace(android.R.id.content, frag3);
            return;

        }

    }

    @Override
    public void onTabUnselected(Tab tab, FragmentTransaction ft) {
        // TODO Auto-generated method stub
    }

    @Override
    public void onTabReselected(Tab tab, FragmentTransaction ft) {
        // TODO Auto-generated method stub
    }
}

}

And here is first Fragment,

public class FeedsActivity extends SherlockFragment {

public static String[] MainCategory; 
public static String[] MainCategoryId; 
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup group,
        Bundle saved) {
    setRetainInstance(true);
    return inflater.inflate(R.layout.activity_feeds, group, false);
}



@Override
public void onActivityCreated(Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);



         new GetMainCategory(getActivity()).execute();




}
}

When I select second tab and then select first tab the async task in first fragment is called again.How can I retain state of first fragment so that its view is created once? I have used setRetainInstance(true) but didnt work.


Solution

  • I solved this issue by using show and hide instead of attach and detach.

       private class MyTabListener implements ActionBar.TabListener {
            @Override
            public void onTabSelected(Tab tab, FragmentTransaction ft) {
    
                switch (tab.getPosition()) {
                case 0:
    
                    if (frag1 == null) {
                        // If not, instantiate and add it to the activity
                        frag1 = Fragment.instantiate(getApplicationContext(),
                                FeedsActivity.class.getName());
                        ft.add(android.R.id.content, frag1, "Feeds");
                    } else {
                        // If it exists, simply attach it in order to show it
                        ft.show(frag1);
                    }
                    return;
    
                case 1:
                    if (frag2 == null) {
                        // If not, instantiate and add it to the activity
                        frag2 = Fragment.instantiate(getApplicationContext(),
                                ProfileActivity.class.getName());
                        ft.add(android.R.id.content, frag2, "Profile");
                    } else {
                        // If it exists, simply attach it in order to show it
                        ft.show(frag2);
                    }
                    return;
                case 2:
    
                    if (frag3 == null) {
                        // If not, instantiate and add it to the activity
                        frag3 = Fragment.instantiate(getApplicationContext(),
                                History.class.getName());
                        ft.add(android.R.id.content, frag3, "History");
                    } else {
                        // If it exists, simply attach it in order to show it
                        ft.show(frag3);
                    }
    
                    return;
    
                }
    
            }
    
            @Override
            public void onTabUnselected(Tab tab, FragmentTransaction ft) {
                // TODO Auto-generated method stub
                if (frag1 != null) {
                    // Detach the fragment, because another one is being attached
                    switch (tab.getPosition()) {
                    case 0:
                        ft.hide(frag1);
                        return;
                    case 1:
                        ft.hide(frag2);
                        return;
                    case 2:
                        ft.hide(frag3);
                        return;
    
                    }
    
                }
            }
    
            @Override
            public void onTabReselected(Tab tab, FragmentTransaction ft) {
                // TODO Auto-generated method stub
            }
        }