Search code examples
androidnullpointerexceptionwallpaperbitmapfactory

Android Wallpaper Managerdoes not create an object (NPE)


I'm trying to create a simple gallery application with as wallpaper option, but every time I get a Null Pointer Exception in a: myWallpaperManager.setBitmap(mBitmap) line. Here is my code:

package com.pbsoft.galeria;
import java.io.IOException;
import android.app.Activity;
import android.os.Bundle;
import android.widget.Button;
import android.widget.ImageView;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.View.OnClickListener;
import android.app.WallpaperManager;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;


public class MainActivity extends Activity {


Button button;
Button button2;
ImageView image;
MenuItem item;
int checkImg;
Bitmap mBitmap;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    checkImg=0;
    addListenerOnButton();
}

public void addListenerOnButton() {
    image = (ImageView) findViewById(R.id.imageView1);
    button = (Button) findViewById(R.id.btnChangeImage);
    button2= (Button) findViewById(R.id.btnPrevious);

    button.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {

            if(checkImg<3)
                ++checkImg;
            else
                checkImg=0;

            setImg();   
        }
    });

    button2.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {
            if(checkImg>0)
                --checkImg;
            else
                checkImg=3;

            setImg();
        }
    });
}

protected void setImg() {
    switch(checkImg){
    case 0: image.setImageResource(R.drawable.wilku); break;
    case 1: image.setImageResource(R.drawable.kotek); break;
    case 2: image.setImageResource(R.drawable.piesek); break;
    case 3: image.setImageResource(R.drawable.chomik); break;
    }       
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is present.
    getMenuInflater().inflate(R.menu.main, menu);
    item = (MenuItem) findViewById(R.id.action_settings);       
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item){
    mBitmap = BitmapFactory.decodeResource(getResources(),image.getId());

    switch (item.getItemId()) {
    case R.id.action_settings:
        WallpaperManager myWallpaperManager = WallpaperManager.getInstance(getApplicationContext());//<-this I think could be not created
        try{
            myWallpaperManager.setBitmap(mBitmap); // <- 91 line, here I get an exception
            finish();
        } catch (IOException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
        return true;
    default:
        return super.onOptionsItemSelected(item);
    }   
}

}

For me it looks like problem with myWallpaperManager object - it's not initialized, but why? I also have put a permission in the manifest: "uses-permission android:name="android.permission.SET_WALLPAPER" /" but it still doesnt work. I'm very new into android, it could be noob question, but please help - thanks for every answer!

Here is also my logcat:

04-12 12:20:31.180: E/AndroidRuntime(3012): FATAL EXCEPTION: main
04-12 12:20:31.180: E/AndroidRuntime(3012): java.lang.NullPointerException
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.app.WallpaperManager.setBitmap(WallpaperManager.java:494)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.pbsoft.galeria.MainActivity.onOptionsItemSelected(MainActivity.java:91)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.app.Activity.onMenuItemSelected(Activity.java:2205)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.policy.impl.PhoneWindow.onMenuItemSelected(PhoneWindow.java:777)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:143)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:855)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.view.menu.IconMenuView.invokeItem(IconMenuView.java:532)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.view.menu.IconMenuItemView.performClick(IconMenuItemView.java:122)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.view.View$PerformClick.run(View.java:9112)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.os.Handler.handleCallback(Handler.java:587)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.os.Handler.dispatchMessage(Handler.java:92)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.os.Looper.loop(Looper.java:130)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at android.app.ActivityThread.main(ActivityThread.java:3835)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at java.lang.reflect.Method.invokeNative(Native Method)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at java.lang.reflect.Method.invoke(Method.java:507)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
04-12 12:20:31.180: E/AndroidRuntime(3012):     at dalvik.system.NativeStart.main(Native Method)

Solution

  • mBitmap = BitmapFactory.decodeResource(getResources(),image.getId());
    

    Here bitmap is null that is why it is throwing null pointer exception. Try to give a valid reasource_id. image.getId()instead of this give R.drawable.your_resource_id.