Search code examples
loggingtclcisco

TCL: Grouping tunnel message together by date day and tunnel


Hi I'm pretty new to TCL coding and wrote this script with the help of this site. I was wondering if there is a better/cleaner way to write this?

set y [read -nonewline [set f [open "tmp.txt" r]]];


array set counts [list];
foreach message [split $y "\n"] {
        # This gets the status, ie: DOWN/UP/OFFLINE.
        set status [lindex [split $message] end]; # will assign last field
        set mon [lindex [split $message] 1]; # number represents the filed number
        set day [lindex lindex[split $message] 2];
        if {$day ==""} {
            set day [lindex [split $message] 3];
        } else {
            set day [lindex [split $message] 2]
        }
    # +number represents the counter
        if {[info exists counts($mon,$day,$status)]} {
                set counts($mon,$day,$status) [expr {$counts($mon,$day,$status)+1}] 
        } else {
                set counts($mon,$day,$status) 1
        }   
}

# sort based for down type evetns
puts "\n\nTabl: Down per day"
puts "\n\n MMM DD || Cnt Status"
puts " ====================="

foreach count [lsort -increasing -unique [array names counts]] {
        foreach {mon day status} [split $count ","] { break; }
        if {$status =="down"} {
            puts " $mon $day || [set counts($count)] \t $status"
        }

    }
# process tunnels that are down and flapped 3 times

array set countsT [list];
foreach message [split $y "\n"] {
        # This gets the status, ie: DOWN/UP/OFFLINE.
        set status [lindex [split $message] end];
        set mon [lindex [split $message] 1];
        set day [lindex [split $message] 2];
        set Tunnx [lindex [split $message] 9];

        if {$day ==""} {
            set day [lindex [split $message] 3];
            set Tunnx [lindex [split $message] 10]
        } else {
            set day [lindex [split $message] 2]
        }

        if {[info exists countsT($mon,$day,$Tunnx,$status)]} {
            set countsT($mon,$day,$Tunnx,$status) [expr {$countsT($mon,$day,$Tunnx,$status)+1}]
        } else {
                set countsT($mon,$day,$Tunnx,$status) 1
        }
}

puts "\n\nTabl: Tunnel = Flap >3"
puts "\n\n MMM DD || Tunnelx\tCnt\t Status"
puts " ================================="

foreach count [lsort -increasing -unique [array names countsT]] {

        if {[set countsT($count)] < 2} { continue; } {
            foreach {mon day tun n status} [split $count ","] { break; } 
            if {$status =="down"} {
                puts " $mon $day || $tun \t [set countsT($count)] \t$status"
        }
    }
}
if {[info exists f]} { close $f }

Sample log:

670555: Mar  9 23:39:18.214: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670557: Mar  9 23:39:50.877: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670559: Mar  9 23:41:08.662: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel4, changed state to down
670561: Mar  9 23:41:18.309: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel3, changed state to down
670562: Mar  9 23:43:13.237: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670564: Mar  9 23:45:26.549: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670567: Mar  9 23:46:45.708: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel3, changed state to down
670570: Mar  9 23:49:31.222: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670574: Mar  9 23:53:14.295: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670576: Mar  9 23:55:49.217: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670577: Mar  9 23:56:16.180: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670581: Mar  9 23:56:45.480: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel3, changed state     to down
670583: Mar  9 23:59:54.080: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670585: Mar 10 00:00:33.224: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670587: Mar 10 00:04:03.292: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670589: Mar 10 00:04:38.921: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel3, changed state to down
670590: Mar 10 00:05:00.505: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670593: Mar 10 00:06:22.473: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670596: Mar 10 00:09:07.262: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670598: Mar 10 00:11:11.294: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down
670602: Mar 10 00:14:23.649: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel1, changed state to down
670604: Mar 10 00:14:59.296: %LINEPROTO-5-UPDOWN: Line protocol on Interface Tunnel2, changed state to down


 Results:

 Tabl: Down per day


 MMM DD || Cnt Status
 =====================
 Mar 10 || 9     down
 Mar 9 || 13     down


 Tabl: Tunnel = Flap >3


  MMM DD || Tunnelx      Cnt      Status
  =================================
  Mar 10 || Tunnel1       4      down
  Mar 10 || Tunnel2       4      down
  Mar 9 || Tunnel1        2      down
  Mar 9 || Tunnel2        7      down
  Mar 9 || Tunnel3        3      down

UPDATE:

Required to record the amount of tunnels that flapped over the day.

Using the table below for a data reference the new table would be Mar 10 2 tunnels that flapped and Mar 9th 3 tunnels.

I can't see how to work out the additional grouping of tunnelx field to count number flapped tunnels.

  MMM DD || Tunnelx      Cnt      Status
  =================================
  Mar 10 || Tunnel1       4      down
  Mar 10 || Tunnel2       4      down
  Mar 9 || Tunnel1        2      down
  Mar 9 || Tunnel2        7      down
  Mar 9 || Tunnel3        3      down

Solution

  • Some notes:

    • you don't have to loop through the file twice, just accumulate the arrays in the first loop
    • the idiomatic way to read a file line by line is with while {[gets ... as I've shown
    • as you've seen, split only splits on a single whitespace char. I've demonstrated using regexp to collect the fields.

    I'd do this:

    array set counts [list]
    array set countsT [list]
    
    set f [open tmp.txt r]
    
    while {[gets $f message] != -1} {
        set fields [regexp -all -inline {\S+} $message]
        set mon [lindex $fields 1] 
    
        # use day "09" instead of "9" so it gets the sorting right.
        set day [format %02d [lindex $fields 2]]
    
        # have to be careful to remove the trailing comma from the tunnel
        set Tunnx [string trimright [lindex $fields 9] ,]
    
        set status [lindex $fields end] ;# will assign last field
    
        incr counts($mon,$day,$status) 
        incr countsT($mon,$day,$Tunnx,$status) 
    }
    
    close $f
    
    
    # sort based for down type evetns
    puts "\n\nTabl: Down per day"
    puts "\n\n MMM DD || Cnt Status"
    puts " ====================="
    
    # don't need "-unique" flag: array keys will be unique
    foreach count [lsort -increasing [array names counts]] {
        foreach {mon day status} [split $count ","] { break }
        if {$status eq "down"} {
            puts [format "%s %s || %3d\t%s" $mon $day $counts($count) $status]
        }
    }
    
    puts "\n\nTabl: Tunnel = Flap >3"
    puts "\n\n MMM DD || Tunnelx\tCnt\t Status"
    puts " ================================="
    
    foreach count [lsort -increasing [array names countsT]] {
        if {$countsT($count) < 2} { continue } 
        foreach {mon day tun status} [split $count ","] { break } 
        if {$status eq "down"} {
            puts [format " %s %s || %s\t%3d\t%s" $mon $day $tun $countsT($count) $status]
        }
    }