Search code examples
c#genericsencapsulationaccess-modifiers

Why is it not "inconsistent accessibility" to use a private nested type inside a generic type in the interface list?


In case the title is not completely self-explanatory, here's the code that puzzles me:

public interface IFoo<T>
{
}

public class MyClass : IFoo<MyClass.NestedInMyClass>
{
  private class NestedInMyClass
  {
  }
}

I'm suprised this compiles with no error. It feels like I'm exposing a private type. Shouldn't this be illegal?

Maybe your answers will simply be "There's no rule against that, so why wouldn't it be OK?" Perhaps it's equally surprising that MyClass.NestedInMyClass is even in "scope". If I remove the MyClass. qualification, it will not compile.

(If I change IFoo<> into a generic class, which should then become base class of MyClass, this is illegal, for a base type must be at least as accessible as the type itself.)

I tried this with the C# 4 compiler of Visual Studio 2010.


Solution

  • No external code can cast the object to this interface, so it's not an accessibility issue.

    public classes are even allowed to implement private or internal interfaces - and similarly, no cast can actually occur from external code.

    Re: discussion about implementations that depend on T - you'll be allowed it if you use explicit interface implementation - because the methods for the interface are effectively private in that case. E.g.:

    public interface IFoo<T>
    {
      void DoStuff(T value);
    }
    
    public class MyClass : IFoo<MyClass.NestedInMyClass>
    {
      void IFoo<MyClass.NestedInMyClass>.DoStuff(MyClass.NestedInMyClass value)
      {
      }
      private class NestedInMyClass
      {
      }
    }
    

    works (because the interface implementing method isn't exposed by the class itself).