What is your best example of a violation of the Single Responsibility Principle?

Question

I'm looking for some good examples of code that violates the Single Responsibility Principle. Don't show me any examples from Uncle Bob's books or web sites since those are plastered all over the internet, like this one:

interface Modem
{
    public void dial(String pno);
    public void hangup();
    public void send(char c);
    public char recv();
}

Answer 1

The granularity of your OO design is a matter of taste and might be inapropriate for others. Thus, I wouldn't look for examples of breaking the single responsibility principle in some business-logic-class, discussing whether it has too much or too little to do.

In my opinion, the best examples (with worst side-effects) come from breaking the layering of your application. F.ex.:

• Performing business logic in the data access layer (whose only responsibility should be providing persistence access to the application)
• Accessing business services from (through) the domain model (whose only responsibility should be to store most of the application's state)
• Performing complex business logic in the view layer (responsible for data presentation & user input)