Search code examples
androidtimepicker

TimePickerDialog is not displaying / showing


I have a TimePickerDialog that I would like to show the user when she pushes on a button, so that she can choose a time to set the display to (some time other than the current time). Currently when the button is pushed the current time is displayed in a TextView and a Toast. Also the screen Darkens and a small box in the center of screen appears. The TimePickerDialog does not display to the user.

Here's the code;

import java.util.Calendar;
import android.os.Bundle;
import android.app.Activity;
import android.app.Dialog;
import android.app.TimePickerDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.support.v4.app.DialogFragment;
import android.support.v4.app.FragmentActivity;
import android.text.format.DateFormat;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;
import android.widget.TimePicker;
import android.widget.Toast;

public class AddAlarmActivity extends FragmentActivity implements TimePickerDialog.OnTimeSetListener, TimePickerDialog.OnDismissListener {

Button setTime;
public int hour_local;
public int minute_local;
public Dialog onCreateDialog;
public TimePicker timePicker;
public TextView displayAlarm;

static final int TIME_DIALOG_ID = 999;

@Override
public void onCreate(final Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_add_alarm);
    //add a TextView thing to this part

    setTime = (Button) findViewById(R.id.button_set_time);
    displayAlarm = (TextView) findViewById(R.id.tvDisplayTime);

    setTime.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            onCreateDialog(savedInstanceState);
            showTimePickerDialog(timePicker);
            displayAlarm.setText(hour_local + ":" + minute_local);
        }
    }); 


}

public Dialog onCreateDialog(Bundle savedInstanceState) {
    // Use the current time as the default values for the picker

    final Calendar c = Calendar.getInstance();
    hour_local = c.get(Calendar.HOUR_OF_DAY);
    minute_local = c.get(Calendar.MINUTE);

    Context context = getApplicationContext();
    CharSequence text = hour_local + ":" + minute_local;
    int duration = Toast.LENGTH_LONG;

    Toast toast = Toast.makeText(context, text, duration);
    toast.show();

    // Create a new instance of TimePickerDialog and return it
    return new TimePickerDialog(getApplicationContext(), this, hour_local, minute_local,
            DateFormat.is24HourFormat(getApplicationContext()));
}

public void showTimePickerDialog(View v) {
    DialogFragment newFragment = new DialogFragment();
    newFragment.show(getSupportFragmentManager(), "timePicker");
}


public void onDismiss(DialogInterface dialog){

    System.out.println("oui c'est très bon !");

}

public void onTimeSet(TimePicker view, int hour_l, int minute_l) {
   hour_local = hour_l;
   minute_local = minute_l;
    System.out.println("voila");
}
}

Solution

  • I would advice that you follow the developer sites way of doing it:

    • Create a static class that handles the dialog fragment

      public static class TimePickerFragment extends DialogFragment
                              implements TimePickerDialog.OnTimeSetListener {
      
      @Override
      public Dialog onCreateDialog(Bundle savedInstanceState) {
          // Use the current time as the default values for the picker
          final Calendar c = Calendar.getInstance();
          int hour = c.get(Calendar.HOUR_OF_DAY);
          int minute = c.get(Calendar.MINUTE);
      
          // Create a new instance of TimePickerDialog and return it
          return new TimePickerDialog(getActivity(), this, hour, minute,
                  DateFormat.is24HourFormat(getActivity()));
      }
      
      public void onTimeSet(TimePicker view, int hourOfDay, int minute) {
          // Do something with the time chosen by the user
      }
      }
      
    • Call this method in your button on click listener:

      public void showTimePickerDialog(View v) {
          DialogFragment newFragment = new TimePickerFragment();
          newFragment.show(getSupportFragmentManager(), "timePicker");
      }
      

    Source here.